[mtg-808] optimize select for show fungible display option #363
+145
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Jan 15, 2025
| | TokenType::RegularNFT | ||
| | TokenType::CompressedNFT => {} | ||
| TokenType::All => { | ||
| query_builder.push(" UNION ALL "); |
There was a problem hiding this comment.
Do you need union all here? It might return you duplicate asset_ids, which doesn't look like expected behaviour. Although to be fair it should not receive duplicates in this union, I'd suggest using just the UNION here
| @@ -262,14 +296,11 @@ fn add_filter_clause<'a>( | |||
| TokenType::All => { | |||
| query_builder.push(" AND (assets_v3.ast_owner = "); | |||
| query_builder.push_bind(owner_address); | |||
| query_builder.push(" OR (fungible_tokens.fbt_owner = "); | |||
| query_builder.push_bind(owner_address); | |||
There was a problem hiding this comment.
looks like the below if should also be dropped. As well as the whole join on fungible_tokens. Also @n00m4d might be working on a concurrent task with balances. I believe with your change and dropped join Vadim task will also be solved.
kstepanovdev
force-pushed
the
fix/optimize-select-for-show_fungible-display-option
branch
2 times, most recently
from
6ea2016 to
24edbb4
Compare
kstepanovdev
requested review from
StanChe,
n00m4d,
andrii-kl and
armyhaylenko
kstepanovdev
force-pushed
the
fix/optimize-select-for-show_fungible-display-option
branch
from
24edbb4 to
9b02344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR optimizes the search request via dropping OR condition if a search for all token types is requested. OR condition in such case provokes seq scan through the table.
To avoid this, UNION between two selects is used instead.