[mtg-578] Penalties/block the clam operation #39
Conversation
programs/rewards/src/state/mining.rs
Outdated
| @@ -32,6 +32,9 @@ pub struct WrappedImmutableMining<'a> { | |||
| pub weighted_stake_diffs: &'a MiningWeightedStakeDiffs, | |||
| } | |||
|
|
|||
| pub const ACCOUNT_TYPE_BIT: usize = 0; | |||
There was a problem hiding this comment.
Right now it's byte, not bit. But using bits for that kind of bools makes sense as we're introducing several restrictions. Wdyt of using a bitmap?
There was a problem hiding this comment.
If you mean a dedicated structure from some crate (or self-written), I'm not sure it may be used without headache with Pod because bool is an u8 in fact and bool is not Pod.
|
|
||
| let mining_data = &mut (*mining.data).borrow_mut(); | ||
| let wrapped_mining = WrappedMining::from_bytes_mut(mining_data)?; | ||
|
|
There was a problem hiding this comment.
Mining is not related to pool (potentially)
There was a problem hiding this comment.
Could you please explain what you mean? Mining is a PDA from a pool's address.
There was a problem hiding this comment.
However, it's used to verify the signer is that program which was expected.
| /// 2-7: unused | ||
| /// 0: account type | ||
| /// 1: claim is restricted | ||
| /// 2-6: unused | ||
| pub data: [u8; 7], |
There was a problem hiding this comment.
Why not put the data in the named fields?
There was a problem hiding this comment.
I consider it tedious to re-shuffle the memory layout each time. Also, see no benefits for having it as a dedicated bool.
Co-authored-by: Stanislav Cherviakov <stchervyakov@gmail.com>
No description provided.