PR changes

metal-toolbox · Oct 8, 2024 · 39c05ee · 39c05ee
1 parent f776309
commit 39c05ee
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/cmd/bios/bios.go b/cmd/bios/bios.go
@@ -36,13 +36,9 @@ func CreateBiosControlCondition(ctx context.Context, action rctypes.BiosControlA
 
 	var biosURL *url.URL
 	if action == rctypes.SetConfig {
-		if biosFlags.biosConfigURL != "" {
-			biosURL, err = url.Parse(biosFlags.biosConfigURL)
-			if err != nil {
-				return err
-			}
-		} else {
-			log.Fatal("failed to get biosConfigURL for `mctl bios set`, yet is a required option")
+		biosURL, err = url.Parse(biosFlags.biosConfigURL)
+		if err != nil {
+			return err
 		}
 	}
 

diff --git a/cmd/bios/set.go b/cmd/bios/set.go
@@ -10,7 +10,7 @@ import (
 
 var setCmd = &cobra.Command{
 	Use:   "set",
-	Short: "Set BIOS settings to something else",
+	Short: "Set BIOS settings from github config file url",
 	Run: func(cmd *cobra.Command, _ []string) {
 		err := CreateBiosControlCondition(cmd.Context(), rctypes.SetConfig)
 		if err != nil {

diff --git a/docs/mctl_bios.md b/docs/mctl_bios.md
@@ -21,6 +21,6 @@ Manage BIOS settings
 
 * [mctl](mctl.md)	 - mctl is a CLI utility to interact with metal toolbox services
 * [mctl bios reset](mctl_bios_reset.md)	 - Reset BIOS settings to default values
-* [mctl bios set](mctl_bios_set.md)	 - Set BIOS settings to something else
+* [mctl bios set](mctl_bios_set.md)	 - Set BIOS settings from github config file url
 * [mctl bios status](mctl_bios_status.md)	 - Get condition status of server
 
diff --git a/docs/mctl_bios_set.md b/docs/mctl_bios_set.md
@@ -2,7 +2,7 @@
 
 ## mctl bios set
 
-Set BIOS settings to something else
+Set BIOS settings from github config file url
 
 ```
 mctl bios set -s SERVER --bios-config-url BIOSCONFIGURL [flags]