Move more queries to Query namespace, with parent object to call between modules #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/query-parent-object
branch
2 times, most recently
from
478277c to
ecfa323
Compare
haarg
force-pushed
the
haarg/query-parent-object
branch
2 times, most recently
from
e566b56 to
c975bf5
Compare
This allows query objects to fetch the parent object, and then fetch other query objects via it. This makes it much easier for query methods to call other query objects, which is needed for convert some of the model queries.
haarg
force-pushed
the
haarg/query-parent-object
branch
from
c975bf5 to
445d70a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parent object to hold all of the query objects, allowing them to easily access each other. Use this object in most of the controller classes, rather than using the MetaCPAN::Model instance.
Remove all of the no longer used delegated methods in the model set classes. For the set classes that no longer have any of their own methods, remove them.
Move several methods from Model to Query.