Add Source Dispatcher #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
changed the base branch from
master
to
fix_bug_with_conditional_compilation
mat-hek
requested changes
Apr 9, 2024
lib/agora/agora_dispatcher.ex
Outdated
Comment on lines
9
to
18
| def_input_pad(:input, | ||
| flow_control: :auto, | ||
| accepted_format: _any | ||
| ) | ||
|
|
||
| def_output_pad(:output, | ||
| flow_control: :auto, | ||
| accepted_format: _any, | ||
| availability: :on_request | ||
| ) |
There was a problem hiding this comment.
- auto is the default
- add accepted format
lib/agora/agora_dispatcher.ex
Outdated
| if user_id in Map.keys(state.output_pads) do | ||
| {[], state} | ||
| else | ||
| add_pad(state, user_id) |
There was a problem hiding this comment.
why do we send the add_pad notification from handle_pad_added?
lib/agora/agora_dispatcher.ex
Outdated
| @@ -0,0 +1,91 @@ | |||
| defmodule Membrane.Agora.Dispatcher do | |||
| @moduledoc false | |||
There was a problem hiding this comment.
This should be either used somewhere or documented for public use ;) Also, tests are missing
There was a problem hiding this comment.
I have added the documentation and the tests, but as you know there are problems with running these integration tests :/
…echanism to the test.
…. Add ORB circle ci config
varsill
changed the base branch from
fix_bug_with_conditional_compilation
to
master
… the dispatcher when the dispatcher is already running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Membrane.Agora.Dispatchercapable of dispatching the stream output by theMembrane.Agora.Sourcebased on theuser_idfield from the buffers metadata