-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added next-auth for login #1
base: main
Are you sure you want to change the base?
Conversation
assets/draw.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using SVGs over PNG format whenever possible. SVGs can be scaled without losing the quality of the image.
Read more about it here: https://cloudinary.com/guides/image-formats/svg-vs-png-4-key-differences-and-how-to-choose#1-image-quality-and-scaling
src/components/signup/signup.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leverage react-hook-form
with custom hooks(if needed) to DRY-up things
src/components/input/input.tsx
Outdated
export default function Input({ | ||
handleChange, | ||
value, | ||
labelText, | ||
labelFor, | ||
id, | ||
name, | ||
type, | ||
isRequired = false, | ||
placeholder, | ||
customClass, | ||
}: Partial<InputProps>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest reconsidering the usage and consumption of this component and based on that, can we please come up with a more tightly-coupled and fail-safe component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest reconsidering the composition of this component. Can we please come up with a more tightly-coupled and fail-safe component?
…ame wrapper and loading page
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…dleware, correct types
…rved keywords in next-auth, hence have to change "user" model name to "userModel"
No description provided.