Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Is the "_" supposed to be there when there is no variant number? #2917

Closed
wants to merge 1 commit into from
Closed

tweak: Is the "_" supposed to be there when there is no variant number? #2917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/src/components/routeVariantName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const RouteVariantName = ({
const route = useRoute(vehicle.routeId)

const { routeId, viaVariant, headsign } = vehicle
const viaVariantFormatted = viaVariant && viaVariant !== "_" ? viaVariant : ""
const viaVariantFormatted = viaVariant && viaVariant !== "_" ? "_" + viaVariant : ""

const isShuttle = isVehicle(vehicle) && vehicle.isShuttle

Expand All @@ -44,7 +44,7 @@ export const RouteVariantName = ({
aria-label="Route & Variant"
className="c-route-variant-name__route-id"
>
{`${route?.name || routeId}_${viaVariantFormatted}`}
{`${route?.name || routeId}${viaVariantFormatted}`}
</output>
<span>
{/* Underline does not work on this space unless it is inside of a span */}
Expand Down
Loading