Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ex/skate/ors): format directions as "short directions" #2902

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat(ex/skate/ors): format directions as "short directions" #2902

merged 3 commits into from
Dec 3, 2024

Conversation

firestack
Copy link
Member

@firestack firestack requested a review from a team as a code owner November 26, 2024 16:21
@firestack firestack enabled auto-merge (squash) November 26, 2024 19:16
hannahpurcell
hannahpurcell reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplified instructions for keep / sharp / slight are implemented differently from the original ticket. Was there follow-up discussion not captured in the ticket that I'm missing?

lib/skate/open_route_service_api/directions_formatter/MBTA/english.ex Show resolved Hide resolved
test/skate/open_route_service_api_test.exs Outdated Show resolved Hide resolved
lib/skate/open_route_service_api/directions_formatter/MBTA/english.ex Outdated Show resolved Hide resolved
lib/skate/open_route_service_api/directions_formatter/MBTA/english.ex Outdated Show resolved Hide resolved
lib/skate/open_route_service_api/directions_formatter/MBTA/english.ex Outdated Show resolved Hide resolved
@firestack firestack force-pushed the kf/asn/simple-directions branch from ae88499 to c588d63 Compare December 2, 2024 16:31
@firestack firestack force-pushed the kf/asn/simple-directions branch 2 times, most recently from c5c07d6 to 3be48b2 Compare December 2, 2024 18:11
@firestack firestack requested a review from bfauble December 2, 2024 18:12
@firestack
Copy link
Member Author

Feel free to take a look if you have time @bfauble!

@firestack firestack force-pushed the kf/asn/simple-directions branch from 3be48b2 to e13493a Compare December 2, 2024 18:35
hannahpurcell
hannahpurcell approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! This will be so nice to have!

@firestack firestack merged commit 8b73365 into main Dec 3, 2024
15 checks passed
@firestack firestack deleted the kf/asn/simple-directions branch December 3, 2024 14:11
@firestack
Copy link
Member Author

Whoops I forgot automerge was on, if you were going to or were reviewing it, sorry that got swept out from under you @bfauble. I was gonna give you a bit of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

@bfauble bfauble Awaiting requested review from bfauble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell