Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(ts/hooks/useDetour): convert compound match to tags #2606

Closed
wants to merge 1 commit into from
Closed

cleanup(ts/hooks/useDetour): convert compound match to tags #2606

wants to merge 1 commit into from

Conversation

firestack
Copy link
Member

@firestack firestack commented May 20, 2024 •
edited
Loading

Follow on to #2607 which attempts to simplify the conditions to check for finished

@firestack firestack self-assigned this May 20, 2024
@firestack firestack mentioned this pull request May 20, 2024
Merged
@github-actions GitHub Actions
Copy link

Coverage of commit 0d3ea9e

Summary coverage rate:
  lines......: 93.6% (3241 of 3464 lines)
  functions..: 73.3% (1340 of 1827 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 67f6d95 to cd015ef Compare May 20, 2024 13:30
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 0d3ea9e to 38deea4 Compare May 20, 2024 13:30
@github-actions GitHub Actions
Copy link

Coverage of commit 38deea4

Summary coverage rate:
  lines......: 93.6% (3241 of 3464 lines)
  functions..: 73.3% (1340 of 1827 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 38deea4

Summary coverage rate:
  lines......: 93.6% (3241 of 3464 lines)
  functions..: 73.3% (1340 of 1827 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch 4 times, most recently from 0ba679d to 588dcc8 Compare May 23, 2024 12:01
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 38deea4 to c9f933e Compare May 23, 2024 12:01
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 588dcc8 to 501720f Compare May 23, 2024 12:09
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from c9f933e to 43f270f Compare May 23, 2024 12:09
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 501720f to 9c4e8a9 Compare May 23, 2024 12:14
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch 2 times, most recently from c8a0ad7 to 868c131 Compare May 23, 2024 12:20
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 9c4e8a9 to d5b7929 Compare May 23, 2024 12:20
@github-actions GitHub Actions
Copy link

Coverage of commit 868c131

Summary coverage rate:
  lines......: 93.5% (3241 of 3465 lines)
  functions..: 73.3% (1340 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit c8a0ad7

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 868c131

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 868c131

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from d5b7929 to 66059e7 Compare May 23, 2024 12:40
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch 2 times, most recently from 6885c88 to 1d9b0f5 Compare May 23, 2024 12:46
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 66059e7 to ea2d193 Compare May 23, 2024 12:46
@firestack firestack changed the title cleanup(ts/hooks/useDetour): convert complex match to tags cleanup(ts/hooks/useDetour): convert compound match to tags May 23, 2024
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 1d9b0f5 to 4dd8d9e Compare May 23, 2024 12:47
@github-actions GitHub Actions
Copy link

Coverage of commit 4dd8d9e

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 4dd8d9e

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack requested a review from a team as a code owner May 23, 2024 12:57
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 4dd8d9e to 3872002 Compare May 23, 2024 14:28
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from ea2d193 to 9f49793 Compare May 23, 2024 14:28
@github-actions GitHub Actions
Copy link

Coverage of commit 3872002

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 3872002

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 9f49793 to 68083f2 Compare May 23, 2024 15:30
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 3872002 to a040fcd Compare May 23, 2024 15:30
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 68083f2 to 068d537 Compare May 23, 2024 15:36
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from a040fcd to 259f95d Compare May 23, 2024 15:36
@github-actions GitHub Actions
Copy link

Coverage of commit 259f95d

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 259f95d

Summary coverage rate:
  lines......: 93.5% (3241 of 3465 lines)
  functions..: 73.3% (1340 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 068d537 to def441d Compare May 23, 2024 16:00
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from 259f95d to 34b0311 Compare May 23, 2024 16:00
@github-actions GitHub Actions
Copy link

Coverage of commit 34b0311

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from def441d to 92f6acb Compare May 23, 2024 16:11
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch 3 times, most recently from 801b5ea to fb630fb Compare May 23, 2024 16:19
@github-actions GitHub Actions
Copy link

Coverage of commit fb630fb

Summary coverage rate:
  lines......: 93.5% (3241 of 3465 lines)
  functions..: 73.3% (1340 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit e45de6a

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack @joshlarson
cleanup(ts/hooks/useDetour): convert compound match to tags
0da4233 
Co-authored-by: Josh Larson <jlarson@mbta.com>
@firestack firestack force-pushed the kf/asn/state-machine/use-tags branch from e45de6a to 0da4233 Compare May 23, 2024 21:52
@firestack firestack force-pushed the kf/asn/state-machine/waypoints branch from 45497e3 to b82164e Compare May 23, 2024 21:52
@github-actions GitHub Actions
Copy link

Coverage of commit 0da4233

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 0da4233

Summary coverage rate:
  lines......: 93.6% (3242 of 3465 lines)
  functions..: 73.4% (1341 of 1828 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

hannahpurcell
hannahpurcell approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhhhhhhhhh!! I didn't quite understand the tag comment before, but this explains it. I like. 👍

@firestack firestack requested a review from joshlarson May 28, 2024 14:13
@joshlarson
Copy link
Contributor

I made a bunch of comments on #2607, but I wonder if this PR solves a problem that would already be solved by addressing #2607 (comment)?

@firestack firestack closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

@joshlarson joshlarson Awaiting requested review from joshlarson

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firestack @joshlarson @hannahpurcell