feat: add support for Consul prepared queries #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consul prepared queries are very usefull as they provide automatic fallback between datacenters. This patch adds support for them while keeping the API backward compatible. As prepared queries cannot be watched like services, a new parameter `poll-interval` is introduced to control the poll frequency.
|
Hey, did you have time to have a look at this ? |
|
Hello. Sorry for the delayed answer, lost my notifications from GH. I did clean-up with paying technical debt, could you please adjust your PR and i will look into that ASAP. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul prepared queries are very usefull as they provide automatic fallback between datacenters.
This patch adds support for them while keeping the API backward compatible.
As prepared queries cannot be watched like services, a new parameter
poll-intervalis introduced to control the poll frequency.