Implemented Issue #13 - Add reader mode information to reader metadata object

[beamerblvd]

Implemented issue #13. Compiled libmaxminddb locally, compiled maxminddb.extension against it locally, and tested with all modes explicit and with MODE_AUTO. Works great!

[oschwald]

Thanks for the PR. The metadata is metadata associated with the database file. I think this might be more appropriate as a property on the reader class itself.

[beamerblvd]

That's easy enough. I'll tweak the PR and resubmit in an hour or so.

On Apr 7, 2015, at 17:47, Gregory Oschwald notifications@github.com wrote:

Thanks for the PR. The metadata is metadata associated with the database file. I think this might be more appropriate as a property on the reader class itself.

—
Reply to this email directly or view it on GitHub.

[mattrobenolt]

Just a drive by opinion, if this is done, why not use the constants already available, then you could assert against them? Like:

assert db.mode == maxminddb.MODE_MMAP_EXT

Instead of then using a string prone to typos, etc.

On a more related node, we confirm that the C extension is installed by just checking python -c 'import maxminddb.extension; maxminddb.extension.Reader' and this would error and exit with something non-0.

It's not perfect, but it works since you're right, it's pretty opaque on what's being used. I think this check is sufficient though since if you're using AUTO, the only options in reality are MMAP_EXT or MMAP, unless for some reason you're running on a python that doesn't even have mmap (I'm not even aware of when this condition would happen). The C extension only supports mmap. So this check is sufficient to assert which mode we're going to get at CI/build time.