Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix underscore-containing url routing #19

Merged
merged 1 commit into from
Jan 25, 2012

Conversation

bmount
Copy link
Contributor

@bmount bmount commented Jan 25, 2012

This is a little bugfix for twitter handles with underscores in them getting routed to a chunk of their name as the db resource and then an error message. Partial fix for issue #17.

max-mapper added a commit that referenced this pull request Jan 25, 2012
fix underscore-containing url routing
@max-mapper max-mapper merged commit 1acecaa into max-mapper:master Jan 25, 2012
@max-mapper
Copy link
Owner

kewl. Thanks for fixing this. We should figure out a way to get it upstream to sugar skull (which is now called director)

@bmount
Copy link
Contributor Author

bmount commented Jan 25, 2012

Yeah I looked, I think it is more than half fixed in director https://github.com/flatiron/director/blob/master/build/director-1.0.7.js#L311, but I think it would still break on an :url_rule_w_underscores. I will check it out and see if I can fix/needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants