Feature/solution 2 #4
Conversation
p-rosit
force-pushed
the
feature/solution_2
branch
from
c551bd5 to
b04b2ef
Compare
| self.skill(Selector())( | ||
| self.skill("OpenLocation", "", remap={"OpenableLocation": "ObjectTargetLocation"}), | ||
| self.skill("Success", ""), | ||
| ), |
There was a problem hiding this comment.
It would be nice to find a neat way around this.
One can probably work with the different preconditions on an implementation of a skill description
| skill.setProcessor(SerialStar()) | ||
| skill( | ||
| self.skill("Navigate", "", remap={"TargetLocation": "ObjectTargetLocation"}), | ||
| self.skill("BbUnsetParam", "", remap={"Parameter": "StartLocation"}), |
There was a problem hiding this comment.
These look really ugly. #2 should get some attention
| self.skill("Navigate", "", remap={"TargetLocation": "ObjectStartLocation"}), | ||
| self.skill("BbUnsetParam", "", remap={"Parameter": "StartLocation"}), | ||
| self.skill("Pick", ""), | ||
| self.skill("Navigate", "", remap={"TargetLocation": "ObjectTargetLocation"}), | ||
| self.skill("Place", "", remap={"PlacingLocation": "ObjectTargetLocation"}), |
There was a problem hiding this comment.
This is pretty much problem 1. Maybe a "fetch skill" would be a good idea to avoid duplication
|
I think that one criteria for every "solution" skill could be that one only need to run it once and the problem would be solved. Everything else is done internally. Maybe as a part of that, it would also make sense to make some more knowledge modeling. E.g. waste items and the dumpster could become special. One other thing to consider is that >= problem 3, actions can fail with some probability and all the skills needed there should take that into account. |
|
I'll merge this for now, since I want to order some files and have some other things to push |
Changes: