This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
[Rust] fix multiple lines in markdown mode #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
============================================
+ Coverage 87.49% 89.49% +2.00%
============================================
Files 166 118 -48
Lines 18993 16912 -2081
Branches 1030 616 -414
============================================
- Hits 16617 15136 -1481
+ Misses 2074 1752 -322
+ Partials 302 24 -278
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust changes LGTM, but maybe we could add some comments to explain why they're needed?
…nto mauroromito/fix_markdown_multiple_lines # Conflicts: # platforms/ios/example/Wysiwyg/Views/ContentView.swift # platforms/ios/lib/WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygComposerView.swift # platforms/ios/lib/WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygTextView.swift # platforms/ios/lib/WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygKeyCommand.swift
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown mode was not able to parse newlines, and when the number of consecutive newlines was more than 1 the model generation panicked, resulting in an empty DOM when sending the message.
This makes markdown mode more stable, by allowing newlines to be parsed correctly.
This PR also removes the shiftEnter KeyCommand from iOS since we never actually use it/override in any project, and it just creates the issue of bypassing the correct shift+enter behaviour in markdown mode, which is the behaviour for the software return keyboard on iOS.
Is probably best to completely remove it until we find a better architecture to handle the key commands.