This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Fix enter right after mention crashing the editor #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
============================================
+ Coverage 87.37% 89.42% +2.05%
============================================
Files 166 86 -80
Lines 18999 15352 -3647
Branches 1052 0 -1052
============================================
- Hits 16600 13729 -2871
+ Misses 2097 1623 -474
+ Partials 302 0 -302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
bmarty
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks. I do not understand everything, but I guess you fixed the issue.
I am wondering if we would need some Rust dev review for such PR (and not a review from https://github.com/orgs/matrix-org/teams/element-android).
Velin92
approved these changes
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #903 .