Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[Android] Improve text view test #896

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[Android] Improve text view test #896

merged 1 commit into from
Nov 29, 2023

Conversation

jonnyandrew
Copy link
Contributor

  • Use Espresso ViewActions instead of onActivity + findViewById.
  • Add FakeClickListener test util.
  • Add assertions for the correct URL being clicked.
  • Add test for parsing a mention and clicking it.

@jonnyandrew jonnyandrew changed the title Improve text view test [Android] Improve text view test Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c74e671) 87.43% compared to head (c1363fd) 87.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #896      +/-   ##
============================================
- Coverage     87.43%   87.28%   -0.15%     
  Complexity      415      415              
============================================
  Files           166      134      -32     
  Lines         18975    17387    -1588     
  Branches       1046      408     -638     
============================================
- Hits          16591    15177    -1414     
+ Misses         2085     1935     -150     
+ Partials        299      275      -24     
Flag Coverage Δ
uitests 65.87% <ø> (-5.32%) ⬇️
uitests-android 65.87% <ø> (-0.05%) ⬇️
uitests-ios ?
unittests 86.57% <ø> (+1.09%) ⬆️
unittests-android 44.94% <ø> (ø)
unittests-ios ?
unittests-rust 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonnyandrew jonnyandrew merged commit a45672e into main Nov 29, 2023
7 checks passed
@jonnyandrew jonnyandrew deleted the jonny/text-view-test branch November 29, 2023 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants