This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
[iOS] Fix for dictation not working properly #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 89.44% 89.39% -0.05%
==========================================
Files 118 86 -32
Lines 16898 15324 -1574
Branches 635 0 -635
==========================================
- Hits 15114 13699 -1415
+ Misses 1760 1625 -135
+ Partials 24 0 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@stefanceriu <3 |
stefanceriu
reviewed
Nov 17, 2023
...WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygTextView.swift
Outdated
Show resolved
Hide resolved
...WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygTextView.swift
Show resolved
Hide resolved
...WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygTextView.swift
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
langleyd
approved these changes
Nov 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a way to intercept dictation, which would not work if the content is reconciliated while the dictation is still in progress, so we delay the
reconciliateIfNeeded()function until the dictation state is false.