This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Android: second iteration for mentions #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `insertAtRoomMentionAtSuggestion` method to be able to insert properly formatted `@room` mentions. - Add a way to track `MentionsState`. - Add better examples for `replaceSuggestionText`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
============================================
- Coverage 89.39% 87.21% -2.18%
- Complexity 0 393 +393
============================================
Files 118 133 +15
Lines 16821 17243 +422
Branches 635 389 -246
============================================
+ Hits 15037 15039 +2
- Misses 1760 1942 +182
- Partials 24 262 +238
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jonnyandrew
approved these changes
Nov 6, 2023
platforms/android/example-compose/src/main/java/io/element/wysiwyg/compose/MainActivity.kt
Outdated
Show resolved
Hide resolved
platforms/android/example-compose/src/main/java/io/element/wysiwyg/compose/MainActivity.kt
Outdated
Show resolved
Hide resolved
platforms/android/example-compose/src/main/java/io/element/wysiwyg/compose/matrix/Mention.kt
Outdated
Show resolved
Hide resolved
platforms/android/example-view/src/main/java/io/element/android/wysiwyg/poc/RichTextEditor.kt
Outdated
Show resolved
Hide resolved
...compose/src/androidTest/java/io/element/android/wysiwyg/compose/RichTextEditorActionsTest.kt
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
jmartinesp
deleted the
android/add-insert-at-room-mention-and-mentionsstate
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertAtRoomMentionAtSuggestionmethod to be able to insert properly formatted@roommentions.MentionsState.replaceSuggestionText.