Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[iOS] Add "shouldReplaceText" API #857

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

alfogrillo
Copy link
Contributor

Sometimes it's useful for the client to ignore the input from the keyboard while keeping the focus on the text view.

@alfogrillo alfogrillo requested a review from a team October 27, 2023 15:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb9644b) 89.50% compared to head (cdbf82f) 89.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   89.50%   89.43%   -0.08%     
==========================================
  Files         116       84      -32     
  Lines       16801    15231    -1570     
  Branches      633        0     -633     
==========================================
- Hits        15038    13622    -1416     
+ Misses       1740     1609     -131     
+ Partials       23        0      -23     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.43% <ø> (+1.18%) ⬆️
unittests-ios ?
unittests-rust 89.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo force-pushed the alfogrillo/should_replace_text_api branch from b76d69c to cdbf82f Compare October 28, 2023 10:33
@alfogrillo alfogrillo force-pushed the alfogrillo/should_replace_text_api branch from cdbf82f to 71e2566 Compare October 30, 2023 08:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alfogrillo alfogrillo merged commit 1d56a56 into main Oct 30, 2023
7 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/should_replace_text_api branch October 30, 2023 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants