Remove workaround for excessive recomposition

platforms/android/example-compose/src/main/java/io/element/wysiwyg/compose/MainActivity.kt

@@ -111,7 +111,7 @@ class MainActivity : ComponentActivity() {
                                 state = state,
                                 modifier = Modifier.fillMaxWidth().padding(10.dp),
                                 style = RichTextEditorDefaults.style(),
-                                onError = Timber::e,
+                                onError = { Timber.e(it) },
                                 resolveMentionDisplay = { _,_ -> TextDisplay.Pill },
                                 resolveRoomMentionDisplay = { TextDisplay.Pill },
                             )

platforms/android/library-compose/src/main/java/io/element/android/wysiwyg/compose/EditorStyledText.kt

@@ -52,21 +52,16 @@ fun EditorStyledText(
         factory = { context ->
             EditorStyledTextView(context)
         },
-        // The `update` lambda is called when the view is first created, and then again whenever the actual `update` lambda changes. That is, it's replaced with
-        // a new lambda capturing different variables from the surrounding scope. However, there seems to be an issue that causes the `update` lambda to change
-        // more than it's strictly necessary. To avoid this, we can use a `remember` block to cache the `update` lambda, and only update it when needed.
-        update = remember(style, typeface, mentionDisplayHandler, text, onLinkClickedListener) {
-            { view ->
-                view.applyStyleInCompose(style)
-                view.typeface = typeface
-                view.updateStyle(style.toStyleConfig(view.context), mentionDisplayHandler)
-                if (text is Spanned) {
-                    view.setText(text, TextView.BufferType.SPANNABLE)
-                } else {
-                    view.setHtml(text.toString())
-                }
-                view.onLinkClickedListener = onLinkClickedListener
+        update = { view ->
+            view.applyStyleInCompose(style)
+            view.typeface = typeface
+            view.updateStyle(style.toStyleConfig(view.context), mentionDisplayHandler)
+            if (text is Spanned) {
+                view.setText(text, TextView.BufferType.SPANNABLE)
+            } else {
+                view.setHtml(text.toString())
             }
+            view.onLinkClickedListener = onLinkClickedListener
         }
     )
 }

platforms/android/library-compose/src/main/java/io/element/android/wysiwyg/compose/RichTextEditor.kt

@@ -22,6 +22,7 @@ import io.element.android.wysiwyg.display.TextDisplay
 import io.element.android.wysiwyg.utils.RustErrorCollector
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import timber.log.Timber
 
 
 /**
@@ -168,16 +169,12 @@ private fun RealEditor(
 
             view
         },
-        // The `update` lambda is called when the view is first created, and then again whenever the actual `update` lambda changes. That is, it's replaced with
-        // a new lambda capturing different variables from the surrounding scope. However, there seems to be an issue that causes the `update` lambda to change
-        // more than it's strictly necessary. To avoid this, we can use a `remember` block to cache the `update` lambda, and only update it when needed.
-        update = remember(style, typeface, mentionDisplayHandler, onError) {
-            { view ->
-                view.applyStyleInCompose(style)
-                view.typeface = typeface
-                view.updateStyle(style.toStyleConfig(view.context), mentionDisplayHandler)
-                view.rustErrorCollector = RustErrorCollector(onError)
-            }
+        update = { view ->
+            Timber.i("RichTextEditor update() called")
+            view.applyStyleInCompose(style)
+            view.typeface = typeface
+            view.updateStyle(style.toStyleConfig(view.context), mentionDisplayHandler)
+            view.rustErrorCollector = RustErrorCollector(onError)
         }
     )
 }