Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for the order in which OTKs are issued #744

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 7, 2024

Per MSC4225, they should be issued in the same order they were uploaded.

Per MSC4225, they should be issued in the same order they were uploaded.
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, just one small query.

tests/csapi/upload_keys_test.go Show resolved Hide resolved
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSC landed so shipit

tests/csapi/upload_keys_test.go Show resolved Hide resolved
@richvdh richvdh merged commit ec15cf2 into main Dec 19, 2024
4 checks passed
@richvdh richvdh deleted the rav/test_otk_ordering branch December 19, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants