Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert SummernoteConfig toolbarOptions code, Array.asList is unmodifiable #1157

Closed
wants to merge 17 commits into from
Closed

Revert SummernoteConfig toolbarOptions code, Array.asList is unmodifiable #1157

wants to merge 17 commits into from

Conversation

r1gm
Copy link
Contributor

@r1gm r1gm commented Oct 17, 2024 •
edited by martin-g
Loading

Fixes #1156

r1gm and others added 16 commits September 10, 2024 10:17
@r1gm
update bootstrap italia to version 2.8.7
db0f05a
@r1gm
typo fix
181af71
@r1gm
exclude dependency, use current wicket-bootstrap webjar version
d9c98f7
@dependabot @martin-g
Bump org.webjars.npm:eonasdan__tempus-dominus from 6.9.9 to 6.9.10 (#…
410a67d 
…1142)

Bumps [org.webjars.npm:eonasdan__tempus-dominus](https://github.com/Eonasdan/tempus-dominus) from 6.9.9 to 6.9.10.
- [Release notes](https://github.com/Eonasdan/tempus-dominus/releases)
- [Commits](Eonasdan/tempus-dominus@v6.9.9...v6.9.10)

---
updated-dependencies:
- dependency-name: org.webjars.npm:eonasdan__tempus-dominus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump ch.qos.logback:logback-classic from 1.5.7 to 1.5.8 (#1141)
ff7be79 
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.5.7 to 1.5.8.
- [Commits](qos-ch/logback@v_1.5.7...v_1.5.8)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump jetty.version from 11.0.23 to 11.0.24 (#1139)
e2e9cf0 
Bumps `jetty.version` from 11.0.23 to 11.0.24.

Updates `org.eclipse.jetty:jetty-server` from 11.0.23 to 11.0.24

Updates `org.eclipse.jetty:jetty-webapp` from 11.0.23 to 11.0.24

Updates `org.eclipse.jetty:jetty-maven-plugin` from 11.0.23 to 11.0.24

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-webapp
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump org.webjars:jquery-ui from 1.13.3 to 1.14.0 (#1140)
81e793f 
Bumps [org.webjars:jquery-ui](https://github.com/webjars/jquery-ui) from 1.13.3 to 1.14.0.
- [Commits](webjars/jquery-ui@jquery-ui-1.13.3...jquery-ui-1.14.0)

---
updated-dependencies:
- dependency-name: org.webjars:jquery-ui
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0 (#1137)
0c403ce 
Bumps org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump maven-surefire-plugin.version from 3.4.0 to 3.5.0 (#1136)
2c25f07 
Bumps `maven-surefire-plugin.version` from 3.4.0 to 3.5.0.

Updates `org.apache.maven.plugins:maven-surefire-plugin` from 3.4.0 to 3.5.0
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.4.0...surefire-3.5.0)

Updates `org.apache.maven.surefire:surefire-junit47` from 3.4.0 to 3.5.0

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.maven.surefire:surefire-junit47
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.8.0 to 3.10…
ce1f068 
….0 (#1135)

Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.8.0 to 3.10.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.8.0...maven-javadoc-plugin-3.10.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.4.0 to 3.5…
5210837 
….0 (#1134)

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.4.0...surefire-3.5.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @martin-g
Bump org.mockito:mockito-core from 5.12.0 to 5.13.0 (#1133)
f5001e5 
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.12.0 to 5.13.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.12.0...v5.13.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@martin-g
Exclude org,webjars.npm:design-tokens-italia for bootstrap-italia theme
7c73d1c 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@r1gm
Merge branch 'martin-g:wicket-10.x-bootstrap-5.x' into wicket-10.x-bo…
75a50e0 
…otstrap-5.x
@r1gm
Merge branch 'martin-g:wicket-10.x-bootstrap-5.x' into wicket-10.x-bo…
5ad013c 
…otstrap-5.x
@r1gm
revert problematic code to the good old code, Arrays.asList is unmodi…
046c015 
…fiable, toolbarOptions need modifiable list.
martin-g
martin-g reviewed Oct 17, 2024
View reviewed changes
...ain/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/editor/SummernoteConfig.java
@@ -1,6 +1,6 @@
package de.agilecoders.wicket.extensions.markup.html.bootstrap.editor;

import java.util.Arrays;
import com.google.common.collect.Lists;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are trying to get rid of Guava usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code acceptable ?

new ArrayList<>(Arrays.asList("picture", "link", "video", "table", "hr"));

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!
Shorter: new ArrayList<>(List.of("picture", "link", "video", "table", "hr"));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affirmative

@martin-g
Copy link
Owner

Please also rebase your clone. There are 16 commits in this PR.

@r1gm r1gm closed this by deleting the head repository Oct 17, 2024
@r1gm
Copy link
Contributor Author

r1gm commented Oct 17, 2024

Please review my new pull request #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using SummernoteEditor causing java.lang.UnsupportedOperationException: remove
2 participants
@r1gm @martin-g