Wicket 10.x bootstrap 5.x panel style #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- text and background is set to the same combination as in BS doc: https://getbootstrap.com/docs/5.3/utilities/background/ - border uses same color as background - samples show panel styles - added PanelTypesPanel References martin-g#1006
martin-g
approved these changes
Dec 11, 2023
...rap-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/panel/PanelType.java
Show resolved
Hide resolved
bootstrap-samples/src/main/java/de/agilecoders/wicket/samples/panels/PanelTypesPanel.java
Show resolved
Hide resolved
martin-g
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Align background classes with Bootstrap 5.3 * Add PanelStyle feature - text and background is set to the same combination as in BS doc: https://getbootstrap.com/docs/5.3/utilities/background/ - border uses same color as background - samples show panel styles - added PanelTypesPanel References #1006 * Add PanelType parameter to the constructor (cherry picked from commit 4fff955)
|
Thank you, @vrozkovec ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds panel style feature #1006.
Samples show implemented panel styles.
This PR also includes changes in #1015 so all BackgroundColorBehavior.Color values could be used.