Converted occurances of PARAM_RAW to appropriate types. See

#3
marcusgreen · Oct 29, 2024 · 0156bca · 0156bca
1 parent 1995f9f
commit 0156bca
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/classes/driprelease.php b/classes/driprelease.php
@@ -160,7 +160,7 @@ public function update_availability(array $tabledata, \stdClass $dripdata) {
         }
         $modulenameplural = get_string('modulenameplural', $dripdata->modtype);
         $msg = get_string('updated', 'moodle', $updatecount). " ".$modulenameplural;
-        $refresh = optional_param('refresh', 0, PARAM_RAW);
+        $refresh = optional_param('refresh', 0, PARAM_INT);
         if (! $refresh) {
             \core\notification::add($msg, \core\notification::SUCCESS);
             rebuild_course_cache($COURSE->id);

diff --git a/driprelease_form.php b/driprelease_form.php
@@ -45,7 +45,7 @@ public function definition() {
         global $CFG, $DB, $PAGE, $COURSE;
 
         require_once($CFG->dirroot . '/course/externallib.php');
-        $modtype = optional_param('modtype', 'quiz', PARAM_RAW);
+        $modtype = optional_param('modtype', 'quiz', PARAM_TEXT);
         $courseid = optional_param('courseid', '', PARAM_INT);
 
         $PAGE->requires->js_call_amd('tool_driprelease/modform', 'init', ['courseid' => $courseid]);
@@ -119,7 +119,7 @@ public function definition() {
             ['value' => $driprelease->sessionlength, 'size' => 2]);
         $mform->addRule('sessionlength', null, 'required', null, 'client');
 
-        $mform->setType('sessionlength', PARAM_RAW);
+        $mform->setType('sessionlength', PARAM_INT);
         $mform->addHelpButton('sessionlength', 'session', 'tool_driprelease');
 
         $mform->addElement('text', 'activitiespersession', get_string('activitiespersession', 'tool_driprelease'), ['size' => '3']);
@@ -273,6 +273,5 @@ public function add_action_buttons($cancel=true, $submitlabel=null, $submit2labe
         }
 
         $mform->addGroup($buttonarray, 'buttonar', '', [' '], false);
-        $mform->setType('buttonar', PARAM_RAW);
     }
 }
diff --git a/view.php b/view.php
@@ -32,7 +32,7 @@
 
 // Course module id.
 $courseid = optional_param('courseid', 0, PARAM_INT);
-$modtype = optional_param('modtype', 'quiz', PARAM_RAW);
+$modtype = optional_param('modtype', 'quiz', PARAM_ALPHANUMEXT);
 
 if (!$courseid) {
     redirect(new moodle_url('/'));