chore!: refactor trait implementations and add traits #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `wrapped` method in `Currency` and its implementations to return a reference, improving efficiency. Simplified the `WETH9` token initialization and retrieval process, reducing redundancy and potential errors. Updated version to 2.1.0 in `Cargo.toml`.
Enhanced several structs across various modules by implementing the `Hash` and `Eq` traits. This ensures consistent behavior for these structs in hashed collections and comparisons.
Refactor multiple trait implementations in `FractionLike` to simplify type constraints and improve readability. Used references in arithmetic operations and metadata access for consistency. Removed redundant clone and conditional checks to streamline the code.
Converted `CurrencyLike` to accept const parameters for handling native and non-native currencies. Updated related types and traits to leverage the new const parameter approach, simplifying the logic and making type definitions more explicit. Removed redundant methods and restructured imports for clarity.
Introduced `NativeCurrency` trait representing native blockchain currencies. Implemented this trait for `Ether` and updated the `prelude` and entity modules accordingly.
Change function parameters in `quote` and `compute_price_impact` to use references instead of values for `CurrencyAmount`. This optimizes memory usage and performance by avoiding unnecessary cloning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use merge commit.