Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict types #13

Merged
merged 2 commits into from
Dec 25, 2023
Merged

restrict types #13

merged 2 commits into from
Dec 25, 2023

Conversation

shuhuiluo
Copy link
Collaborator

No description provided.

Copy link
Owner

@malik672 malik672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, don't think there's a need for the validate and check_address any longer

@malik672 malik672 merged commit 9445828 into malik672:master Dec 25, 2023
1 check passed
@shuhuiluo shuhuiluo deleted the 1225 branch December 26, 2023 00:45
@shuhuiluo
Copy link
Collaborator Author

with this, don't think there's a need for the validate and check_address any longer

Did you start this project for a reason? I contribute because I need a mini port of the v3-sdk to Rust for a company project.

@malik672
Copy link
Owner

with this, don't think there's a need for the validate and check_address any longer

Did you start this project for a reason? I contribute because I need a mini port of the v3-sdk to Rust for a company project

I started the project just to build

@malik672
Copy link
Owner

It's just a personal project

@shuhuiluo
Copy link
Collaborator Author

shuhuiluo commented Dec 26, 2023 via email

@malik672
Copy link
Owner

It seems almost complete except porting over existing JS tests. Are you interested converting the v3-sdk?

On Mon, Dec 25, 2023, 17:02 malik @.> wrote: It's just a personal project — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZUK7KHYYLXFKRFMNTGD7KDYLIO3XAVCNFSM6AAAAABBCKJLXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE3TIOBWGU . You are receiving this because you authored the thread.Message ID: @.>

yeah, still somethings to go. would love to for the v3, but I have another personal project coming up, maybe you can pull something up and let me contribute

@shuhuiluo
Copy link
Collaborator Author

shuhuiluo commented Dec 26, 2023 via email

@malik672
Copy link
Owner

Sounds good. Consider publishing this cargo to crates.io for better package management and SEO.

On Mon, Dec 25, 2023, 17:21 malik @.> wrote: It seems almost complete except porting over existing JS tests. Are you interested converting the v3-sdk? … <#m_-5620361362184208023_> On Mon, Dec 25, 2023, 17:02 malik @.> wrote: It's just a personal project — Reply to this email directly, view it on GitHub <#13 (comment) <#13 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZUK7KHYYLXFKRFMNTGD7KDYLIO3XAVCNFSM6AAAAABBCKJLXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE3TIOBWGU https://github.com/notifications/unsubscribe-auth/AZUK7KHYYLXFKRFMNTGD7KDYLIO3XAVCNFSM6AAAAABBCKJLXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE3TIOBWGU . You are receiving this because you authored the thread.Message ID: @.> yeah, still somethings to go. would love to for the v3, but I have another personal project coming up, maybe you can pull something up and let me contribute — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZUK7KE7HOKRK7G2S4DH3HTYLIRDHAVCNFSM6AAAAABBCKJLXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGE4DANBQGI . You are receiving this because you authored the thread.Message ID: @.**>

will do that

@malik672
Copy link
Owner

@shuhuiluo published it, will add the docs soon enough, probably today

@shuhuiluo
Copy link
Collaborator Author

@shuhuiluo published it, will add the docs soon enough, probably today

Thanks. For the attribution, can you use my GitHub name and Twitter?

@malik672
Copy link
Owner

malik672 commented Dec 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants