require all necessary psr implementations #63
Conversation
composer.json
Outdated
| "ext-json": "*" | ||
| }, | ||
| "require-dev": { | ||
| "php-http/guzzle6-adapter": "^2.0", | ||
| "guzzlehttp/psr7": "^2.0", |
There was a problem hiding this comment.
i suggest to use the guzzle psr 7 implementation when using the guzzle client. but we can also switch back to nyholm, it should not break anything either way.
There was a problem hiding this comment.
ok, with guzzle 6, we would need psr7 version 1 which does not include the factories. i suggest going with guzzle 7 for the tests. that is also compatible with php 8.
the code relies on psr7, psr17 and psr18 implementations to be available, with the discovery. it no longer uses the php-http httplug interface (which was made obsolete by psr-18). php-http/client-common is also not used in the code.
| @@ -25,5 +26,8 @@ | |||
| "psr-4": { | |||
| "MailerLiteApi\\Tests\\": "tests/" | |||
| } | |||
| }, | |||
| "conflict": { | |||
| "php-http/httplug": "< 2" | |||
There was a problem hiding this comment.
adding this conflict to be sure to not break for users who provide their own httplug client implementation. the httplug 2.* interface extends the psr-18 interface to be compatible with both.
|
i tried running the tests locally, but they fail because the tests assume the json is decoded to array, but RestClient::handleResponse does json_decode with i don't think this has anything to do with the changes i propose. but it would be a good idea to fix the tests. |
the code relies on psr7, psr17 and psr18 implementations to be available, with the discovery.
it no longer uses the php-http httplug interface (which was made obsolete by psr-18). php-http/client-common is also not used in the code.