-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/resolve release deploy action warnings #97
base: develop
Are you sure you want to change the base?
Enhancement/resolve release deploy action warnings #97
Conversation
@dkotter, during my testing I saw that the "Deploy to WordPress.org" action will trigger on pre-releases as well. Based on the action, it seems like it should only run when a release is published. We could exclude prereleases with something like this. What do you think? jobs:
tag:
name: New release
runs-on: ubuntu-latest
if: ${{ !github.event.release.prerelease }} # Skip job if it is a pre-release |
@@ -0,0 +1,74 @@ | |||
# TODO: THIS WORKFLOW FILE IS TO TEST ISSUE #60 "Resolve release deploy action warnings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the Deploy to Wordpress.org Github action only runs on the publish event I've added a separate file that comments out the WordPress Plugin Deploy step and generates the zip file for the replaced step last.
This can be deleted once the PR passes code review and QA.
Calling out an annotation warning in the Deploy to WordPress.org action. I don't think any action is required here as this is just an informational message letting us know that ubuntu-latest will be using ubuntu-24.04 soon. |
Description of the Change
Resolve GH warnings during the Deploy to WordPress.org GH action by changing the step that attaches the Mailchimp plugin files to the Github release to use
softprops/action-gh-release@v2
.Description of functionality
GH action triggers on publish of a release. The action deploys the repo to the wordpress.org plugin repo and then updates the GH release with the WP plugin zip file.
Closes #60
How to test the Change
Production testing
Verify the Mailchimp WP plugin zip file is added to the release
(production only) Verify that the Mailchimp WP Plugin is published
Non production testing
test-gh-deploy-to-wordpress.mov
mailchimp/wordpress
repomailchimp.zip
file attached to the releasemailchimp.zip
and verify that all expected production plugin files existChangelog Entry
Credits
Props @MaxwellGarceau
Checklist:
I have updated the documentation accordingly.All new and existing tests pass.Not relevant for Github action changes