fix: make uploader upscale work #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
commented
Oct 25, 2024
| // get the safenode manager version from a random generic node vm | ||
| let safenode_manager_version = genesis_node_registry | ||
| .retrieved_registries | ||
| .iter() | ||
| .find_map(|(_, reg)| reg.daemon.as_ref()) | ||
| .ok_or_else(|| eyre!("Unable to obtain the daemon"))? | ||
| .version | ||
| .parse()?; | ||
| .clone(); | ||
| // FIXME: the safenode manager version from the daemon is not written properly by safenode manager. |
There was a problem hiding this comment.
Issue created in safe_network
RolandSherwin
commented
Oct 25, 2024
| Ok(EnvironmentDetails { | ||
| environment_type, | ||
| deployment_type, | ||
| evm_network: EvmNetwork::ArbitrumOne, |
There was a problem hiding this comment.
This error happened quite a few times and my Custom deployment was broken because of this line. We should not assume the evm_network
jacderida
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.