feat: add option to suppress stderr

src/ansible.rs

@@ -115,6 +115,7 @@ impl AnsibleRunnerInterface for AnsibleRunner {
                 "--list".to_string(),
             ],
             true,
+            false,
         )?;
 
         // Debug the output of the inventory list.
@@ -175,6 +176,7 @@ impl AnsibleRunnerInterface for AnsibleRunner {
             self.working_directory_path.clone(),
             args,
             false,
+            false,
         )?;
         Ok(())
     }

src/lib.rs

@@ -622,7 +622,8 @@ pub fn run_external_command(
     binary_path: PathBuf,
     working_directory_path: PathBuf,
     args: Vec<String>,
-    suppress_output: bool,
+    suppress_stdout: bool,
+    suppress_stderr: bool,
 ) -> Result<Vec<String>> {
     let mut command = Command::new(binary_path.clone());
     for arg in &args {
@@ -635,27 +636,28 @@ pub fn run_external_command(
     debug!("Working directory set to {working_directory_path:#?}");
 
     let mut child = command.spawn()?;
-    let mut output_lines = Vec::new();
+    let mut stdout_lines = Vec::new();
+    let mut stderr_lines = Vec::new();
 
     if let Some(ref mut stdout) = child.stdout {
         let reader = BufReader::new(stdout);
         for line in reader.lines() {
             let line = line?;
-            if !suppress_output {
-                println!("{}", &line);
+            if !suppress_stdout {
+                println!("{line}");
             }
-            output_lines.push(line);
+            stdout_lines.push(line);
         }
     }
 
     if let Some(ref mut stderr) = child.stderr {
         let reader = BufReader::new(stderr);
         for line in reader.lines() {
             let line = line?;
-            if !suppress_output {
-                println!("{}", &line);
+            if !suppress_stderr {
+                eprintln!("{line}");
             }
-            output_lines.push(line);
+            stderr_lines.push(line);
         }
     }
 
@@ -666,7 +668,7 @@ pub fn run_external_command(
         return Err(Error::ExternalCommandRunFailed(binary_path.to_string()));
     }
 
-    Ok(output_lines)
+    Ok(stdout_lines)
 }
 
 pub fn is_binary_on_path(binary_name: &str) -> bool {

src/logs.rs

@@ -87,6 +87,7 @@ impl TestnetDeploy {
                     PathBuf::from("."),
                     vec!["-R".to_string(), format!("{ip_address}")],
                     false,
+                    false,
                 ) {
                     println!("Failed to ssh-keygen {vm_name:?} : {ip_address} with err: {err:?}");
                 } else if let Err(err) =
@@ -118,6 +119,7 @@ impl TestnetDeploy {
             PathBuf::from("."),
             rsync_args_clone.clone(),
             true,
+            false,
         )?;
 
         debug!("Finished rsync for for {vm_name:?} : {ip_address}");

src/rpc_client.rs

@@ -49,6 +49,7 @@ impl RpcClientInterface for RpcClient {
             self.working_directory_path.clone(),
             vec![rpc_address.to_string(), "info".to_string()],
             false,
+            false,
         )?;
 
         let endpoint = output

src/safe.rs

@@ -51,6 +51,7 @@ impl SafeClientInterface for SafeClient {
                 "download".to_string(),
             ],
             false,
+            false,
         )?;
         Ok(())
     }
@@ -67,6 +68,7 @@ impl SafeClientInterface for SafeClient {
                 path.to_string_lossy().to_string(),
             ],
             false,
+            false,
         )?;
 
         let re = Regex::new(r"Uploaded .+ to ([a-fA-F0-9]+)")?;
@@ -93,6 +95,7 @@ impl SafeClientInterface for SafeClient {
                 faucet_addr.to_string(),
             ],
             false,
+            false,
         )?;
         Ok(())
     }

src/ssh.rs

@@ -74,6 +74,7 @@ impl SshClientInterface for SshClient {
                     "--version".to_string(),
                 ],
                 false,
+                false,
             );
             if result.is_ok() {
                 println!("SSH is available.");
@@ -122,6 +123,7 @@ impl SshClientInterface for SshClient {
             std::env::current_dir()?,
             args,
             suppress_output,
+            false,
         )
         .map_err(|_| Error::SshCommandFailed(command.to_string()))?;
         Ok(output)
@@ -159,6 +161,7 @@ impl SshClientInterface for SshClient {
             std::env::current_dir()?,
             args,
             suppress_output,
+            false,
         )
         .map_err(|e| {
             Error::SshCommandFailed(format!(
@@ -185,6 +188,7 @@ impl SshClientInterface for SshClient {
             std::env::current_dir()?,
             args,
             suppress_output,
+            false,
         )
         .map_err(|e| {
             Error::SshCommandFailed(format!("Failed to execute command on remote host: {e}"))

src/terraform.rs

@@ -47,6 +47,7 @@ impl TerraformRunnerInterface for TerraformRunner {
             self.working_directory_path.clone(),
             args,
             false,
+            false,
         )?;
         Ok(())
     }
@@ -57,6 +58,7 @@ impl TerraformRunnerInterface for TerraformRunner {
             self.working_directory_path.clone(),
             vec!["destroy".to_string(), "-auto-approve".to_string()],
             false,
+            false,
         )?;
         Ok(())
     }
@@ -72,6 +74,7 @@ impl TerraformRunnerInterface for TerraformRunner {
             self.working_directory_path.clone(),
             args,
             false,
+            false,
         )?;
         Ok(())
     }
@@ -86,6 +89,7 @@ impl TerraformRunnerInterface for TerraformRunner {
                 name.to_string(),
             ],
             true,
+            false,
         )?;
         Ok(())
     }
@@ -96,6 +100,7 @@ impl TerraformRunnerInterface for TerraformRunner {
             self.working_directory_path.clone(),
             vec!["workspace".to_string(), "list".to_string()],
             true,
+            false,
         )?;
         let workspaces: Vec<String> = output
             .into_iter()
@@ -111,6 +116,7 @@ impl TerraformRunnerInterface for TerraformRunner {
             self.working_directory_path.clone(),
             vec!["workspace".to_string(), "new".to_string(), name.to_string()],
             false,
+            false,
         )?;
         Ok(())
     }
@@ -125,6 +131,7 @@ impl TerraformRunnerInterface for TerraformRunner {
                 name.to_string(),
             ],
             false,
+            false,
         )?;
         Ok(())
     }