Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): use futures stream to speed up downloads #1155

Merged

Conversation

RolandSherwin
Copy link
Member

@RolandSherwin RolandSherwin commented Jan 8, 2024

Description

Summary generated by Reviewpad on 08 Jan 24 18:39 UTC

This pull request contains the following changes:

In the error.rs file:

  • Added a new variant EmptyDataMap to the Error enum. This variant represents the error of an empty data map being provided.

In the sn_client/src/files/mod.rs file:

  • The chunks module is now importing only the Error type from the self_encryption module, instead of the DataMapLevel and SmallFile types.
  • Removed the import of futures::{future::join_all, stream::FuturesOrdered, StreamExt}.
  • Removed the import of itertools::Itertools.
  • Modified the import of self_encryption::{self, decrypt_full_set, ChunkInfo, DataMap, EncryptedChunk, StreamSelfDecryptor, MIN_ENCRYPTABLE_BYTES}. Removed the decrypt_full_set function and types ChunkInfo, DataMap, EncryptedChunk, and StreamSelfDecryptor. Only the MIN_ENCRYPTABLE_BYTES constant remains.
  • Removed the import of std::time::Instant.
  • Removed the import of tokio::task.
  • Removed the import of tracing::trace.
  • Removed the import of xor_name::XorName.
  • Removed several methods of the FilesApi implementation, including read_from, read_all, unpack_chunk, seek, and try_get_chunks.

@reviewpad reviewpad bot requested a review from bochaco January 8, 2024 18:39
@reviewpad reviewpad bot added Large Large sized PR waiting-for-review labels Jan 8, 2024
@RolandSherwin RolandSherwin force-pushed the refactor_cli_downloads_followup branch from 16ff199 to 5df7e5a Compare January 8, 2024 19:34
@joshuef joshuef added this pull request to the merge queue Jan 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2024
@RolandSherwin RolandSherwin added this pull request to the merge queue Jan 9, 2024
Merged via the queue into maidsafe:main with commit 672e176 Jan 9, 2024
30 checks passed
@RolandSherwin RolandSherwin deleted the refactor_cli_downloads_followup branch January 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Large Large sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants