-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: offline signing wallet cmds #1126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bochaco
force-pushed
the
feat-offline-wallet-cmds
branch
2 times, most recently
from
January 3, 2024 18:49
5639420
to
5c83a3a
Compare
bochaco
force-pushed
the
feat-offline-wallet-cmds
branch
6 times, most recently
from
January 5, 2024 19:15
9e8e3e5
to
499b0e6
Compare
bochaco
force-pushed
the
feat-offline-wallet-cmds
branch
from
January 5, 2024 19:17
499b0e6
to
8eed285
Compare
bochaco
force-pushed
the
feat-offline-wallet-cmds
branch
from
January 5, 2024 19:28
8eed285
to
27f5976
Compare
Comment on lines
108
to
110
Error::CashNoteReissueFailed( | ||
"Overflow occurred while summing the amounts for the recipients.".to_string(), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make use of this error instead? Error::ExcessiveNanoValue
? Makes it easily trackable.
RolandSherwin
approved these changes
Jan 9, 2024
b-zee
approved these changes
Jan 9, 2024
…igned offline later on
… for offline signing
… unsigned transactions
…actions signed offline
joshuef
force-pushed
the
feat-offline-wallet-cmds
branch
from
January 9, 2024 15:21
27f5976
to
9dfa00d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 03 Jan 24 17:57 UTC
This pull request includes changes in multiple files. Here is a summary of the diff:
local_store.rs
file now returns a tuple containing aVec
of(CashNote, Option<DerivedSecretKey>)>
instead of(Vec<(CashNote, DerivedSecretKey)>, WalletExclusiveAccess)
in theavailable_cash_notes
function. It also adds thebuild_unsigned_transaction
function.reissue.rs
file in thesn_transfers/benches
directory has modifications in thecreate_offline_transfer
andderive_key
functions. The second element of the tuple parameter in thecreate_offline_transfer
function is now wrapped in anOption
type.offline_transfer.rs
file includes changes in theTranferInputs
struct,create_offline_transfer
function, addition ofbuild_unsigned_transaction
function, modification of theselect_inputs
function, addition ofcreate_transaction_builder_with
function, and addition of thereason_hash
parameter in thecreate_offline_transfer_with
function.builder.rs
file changes the type and parameter ofinput_details
inTransactionBuilder
, as well as the parameter types in theadd_input
andadd_inputs
methods.wallet.rs
file introduces changes related to theCreate
andTransaction
commands, along with the addition of thebuild_unsigned_transaction
andreceive
helper functions.main.rs
file adds a new arm in the match expression for theTransaction
variant in theWalletCmds
enum.mod.rs
file introduces thebuild_unsigned_transaction
function in theoffline_transfer
module.genesis.rs
file modifies thecreate_first_cash_note_from_key
method by adding an optional derived key as an argument in theadd_input
method.Please let me know if you need any further assistance.