Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price slider implementation #4376

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

del22123
Copy link
Collaborator

Description

This PR contains the implementation of price slider in layered navigation.
This Price slider will replace the existing price range filters

Closes #PWA-3389
https://jira.corp.adobe.com/browse/PWA-3389

Acceptance

Verification Stakeholders

Specification

Verification Steps

Step 1: Goto a category page
Step 2: Expand the price filter
Step 3: It should have the working slider instead of existing range filters

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/venia-ui/lib/components/FilterSidebar/__tests__/filterSidebar.spec.js
  • packages/peregrine/lib/talons/FilterModal/__tests__/useFilterBlock.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterList.spec.js
  • packages/peregrine/lib/talons/FormError/__tests__/useFormError.spec.js
  • packages/venia-ui/lib/components/FilterModal/CurrentFilters/__tests__/currentFilter.spec.js
🚫

The following file(s) did not pass ESLint. Execute yarn run lint locally for more details

packages/venia-ui/lib/components/FilterModal/FilterList/filterList.js
packages/venia-ui/lib/components/RangeSlider/rangeSlider.js
Messages
📖

Associated JIRA tickets: PWA-3389.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck


ERROR ON TASK: unitTests


ERROR ON TASK: validateQueries


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 0f73ad4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

3 participants