Migrate from Terraform to OpenTofu #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprankhub
reviewed
Jan 13, 2025
There was a problem hiding this comment.
First, thanks a lot for your PR!
This looks too simple to be true 😂 Did you test this somehow, by chance? Not sure, but who knows - maybe there is a way :)
So you think renaming this repository and then merging this PR should be enough? Or are there additional steps we need to take?
|
/plan |
|
@sprankhub Starting Terraform plan https://github.com/mage-os/terraform/actions/runs/12756324713 |
Terraform Plan
|
|
@davidtabat the "plan" above shows an error, even though it looks okay. Any idea? Do you think it will be gone when we rename this repository? |
|
genuine question: if we rename the repo, shouldn't we rename it to a platform-agnostic one like "infrastructure" or something like that? |
|
@sprankhub Yes I tested it. Described in the taiga ticket comment - how exactly https://tree.taiga.io/project/mage-os-mage-os-technical-initiatives/us/37?kanban-status=9349607 |
|
@fballiano Yes, agree with you, that indeed sounds better. |
|
I agree, but https://github.com/mage-os/infrastructure is taken already :D Other ideas?
|
|
I tested renaming on a dummy repo, and even after renaming it on GitHub, there were still errors due to the state saved in the backend. For now, I’ll take some time to figure out how to do it properly. 😄 Regarding the name, I think 'infrastructure-setup' is good. Maybe we should create a poll in Discord? Or is this too small of a matter to give so much attention to?" |
|
Are we sure that this switch won't result in a lock change or even worse in a re-creation of existing repos? |
|
So, for example, when we destroy the tf repo, can this have an impact on any other repos? |
|
@DavidLambauer It shouldn't, but I will test that here to be sure ofc: https://github.com/orgs/test-opentofu-mageos/repositories. |
I'm nobody to decide anything but I'm fine with infrastructure-setup
I sincerely hope TF doesn't work that way, is there a way to know? |
|
In the early days, I ran into some lock issues, and that's why I am asking. If it's properly tested, we should be fine I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR, I renamed the terraform repository to opentofu in variables.tf for consistency.
Please ensure the repository on GitHub is renamed from terraform to opentofu before merging this PR. Otherwise, merging will trigger the creation of a new repository named opentofu.
If you don't want renaming the repository, let me know, and I will revert the name in variables.tf.