Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snappy: update to 1.2.1 #24055

Merged
merged 1 commit into from
May 21, 2024

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented May 21, 2024

New release 1.2.1 fixes ABI compatibility issue

See: google/snappy#183
Closes: https://trac.macports.org/ticket/70046

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.4.1 23E224 x86_64
Xcode 15.4 15F31d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@ryandesign
Copy link
Contributor

Thanks! Except they have now released 1.2.1 to include this and the previous fix. Do you want to just update to 1.2.1 instead?

Release eventually fixes ABI compatibility issue created by 1.2.0.
Remove patch accordingly.

See: google/snappy#183
Closes: https://trac.macports.org/ticket/70046

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot force-pushed the w21/snappy-fix-incompatibility branch from 7764d0c to 5e7a6d7 Compare May 21, 2024 20:36
@pguyot pguyot changed the title snappy: reinstate previous version of RawCompress function snappy: update to 1.2.1 May 21, 2024
@ryandesign ryandesign merged commit 05d059f into macports:master May 21, 2024
4 checks passed
@pguyot pguyot deleted the w21/snappy-fix-incompatibility branch May 22, 2024 02:50
-project(Snappy VERSION 1.1.10 LANGUAGES C CXX)
+project(Snappy VERSION 1.2.0 LANGUAGES C CXX)

# C++ standard can be overridden when this is used as a sub-project.

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants