Avoid potential race condition edge case

lukebemishprojects · Dec 10, 2024 · ff9bb48 · ff9bb48
1 parent 4c476ac
commit ff9bb48
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/wrapper/src/main/java/dev/lukebemish/immaculate/wrapper/Main.java b/wrapper/src/main/java/dev/lukebemish/immaculate/wrapper/Main.java
@@ -97,19 +97,23 @@ private static void logException(Throwable t) {
     }
 
     private record Output(DataOutputStream output) {
-        synchronized void writeFailure(int id) throws IOException {
-            output.writeInt(id);
-            output.writeBoolean(false);
-            output.flush();
+        void writeFailure(int id) throws IOException {
+            synchronized (this) {
+                output.writeInt(id);
+                output.writeBoolean(false);
+                output.flush();
+            }
         }
 
-        synchronized void writeSuccess(int id, String result) throws IOException {
-            output.writeInt(id);
-            output.writeBoolean(true);
-            byte[] bytes = result.getBytes(StandardCharsets.UTF_8);
-            output.writeInt(bytes.length);
-            output.write(bytes);
-            output.flush();
+        void writeSuccess(int id, String result) throws IOException {
+            synchronized (this) {
+                output.writeInt(id);
+                output.writeBoolean(true);
+                byte[] bytes = result.getBytes(StandardCharsets.UTF_8);
+                output.writeInt(bytes.length);
+                output.write(bytes);
+                output.flush();
+            }
         }
     }
 }