Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Feature/sensor switches #34

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ma-ku
Copy link

@ma-ku ma-ku commented Jan 31, 2021

Hi Lukas,

based on our discussion on #21 i am passing the changes to you. Basically i am adding switches for each opening sensor. These switches can then be controlled by automations in HomeKit. Apart from that, these additional switches can be moved into separate accessories to avoid cluttering the thermostat and also to move these accessories into a room to be out of sight.

@ma-ku
Copy link
Author

ma-ku commented Feb 2, 2021

Addresses issue #32

@WinfriedO
Copy link

There is a typo in the readme
..The additional accessory wull be named like the thermostat accessory ..

@ma-ku
Copy link
Author

ma-ku commented Feb 12, 2021

Hi Lukas, are you going to integrate the PR? I would prefer not to create a one-off but to share the added capabilities.

@ma-ku ma-ku changed the title Feature/sensor switrches Feature/sensor switches Feb 12, 2021
@WinfriedO
Copy link

The priority seems not to be maintainance.. so all this is more or less useless

@ma-ku
Copy link
Author

ma-ku commented Feb 21, 2021

The priority seems not to be maintainance.. so all this is more or less useless

what do you mean? That this is not going to be integrated? I think there is a valid case for this feature.

@WinfriedO
Copy link

There is a close issue where Mr. Rögner said: "I'm not planning to update the dependencies in the near future. The plugin will work even if those warning occur."
So I understand that he doesn't care... I will retire soon and then I will have a look. Perhaps I can create something myself then.

@Tyraenor
Copy link

Tyraenor commented Mar 1, 2021

There is a close issue where Mr. Rögner said: "I'm not planning to update the dependencies in the near future. The plugin will work even if those warning occur."
So I understand that he doesn't care... I will retire soon and then I will have a look. Perhaps I can create something myself then.

The weird thing is, that this would just need to update the version number of "node-tado-client" in the package.json and voila the security issue would be gone... So I totally not get why he refuses to do it...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants