Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48321: Ignore dist-info directory #40

Merged
merged 2 commits into from
Jan 8, 2025
Merged

DM-48321: Ignore dist-info directory #40

merged 2 commits into from
Jan 8, 2025

Conversation

timj
Copy link
Member

@timj timj commented Jan 7, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.21%. Comparing base (24ef238) to head (4a0878a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   47.21%   47.21%           
=======================================
  Files          11       11           
  Lines         377      377           
  Branches       43       43           
=======================================
  Hits          178      178           
  Misses        190      190           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Copy link
Member Author

timj commented Jan 7, 2025

I think the mypy breakage is coming from Parsl/parsl#3690 where they removed the move_files functionality completely. We set it to False, which is now the default. I'm not sure if we can set it to True in older versions of parsl or if we need to check the version number before using move_files.

@timj timj force-pushed the tickets/DM-48321 branch 2 times, most recently from d9ab1de to 579c739 Compare January 7, 2025 22:58
@benclifford
Copy link

I'm not sure if we can set it to True in older versions of parsl or if we need to check the version number before using move_files.

This parameter was removed as part of a broader removal of support for Parsl submitting to remote systems. Almost everyone ignored move_files and left it default, as part of ignoring the "submitting to remote systems" functionality. (see Parsl/parsl#3515 for more info)

For that default handling, there was some code that tried to figure out if your batch system was on the same shared filesystem as your submitting system and if so, do nothing here. That was basically always true (because Parsl's submitting-to-remote-systems code was abandoned long ago and almost no one tried to do it).

In most cases, whatever the value of that parameter, Parsl won't do anything to move files around, because it won't have been configured to try to do remote job submission - and in those cases, it's fine in older Parsl versions for this parameter to be omitted entirely and left to default because it was doing nothing whether it was True or False or whatever.

@airnandez added this in2p3 config, though, and might have had a reason to specially set move_files to False rather than leaving it default, though - I don't have access to in2p3 to actually try stuff out with older versions.

But my initial feeling is that unless there is something particularly different about ccin2p3, this config should work without move_files set at all on older Parsl versions.

This parameter did not ever do anything and was removed in
2024.12.02.
@timj timj force-pushed the tickets/DM-48321 branch from 579c739 to 4a0878a Compare January 8, 2025 15:45
@timj timj merged commit d4d3944 into main Jan 8, 2025
15 checks passed
@timj timj deleted the tickets/DM-48321 branch January 8, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants