Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-46983: Use DefaultingValidator output to render the calibrations configuration in BaseCalsys, new defaults values and cleanups #173

Merged
merged 9 commits into from
Nov 1, 2024

Conversation

MarcoRocchietti
Copy link
Contributor

  • Fix bug: configurations are now updated with default values applied by salobj.DefaultingValidator in BaseCalsys.load_calibration_config_file.
  • Add new default values to atcalsys_schema.yaml and mtcalsys_schema.yaml.
  • Remove attributes from atcalsys.yaml and mtcalsys.yaml that use default values.

Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks

@MarcoRocchietti MarcoRocchietti merged commit 553cd32 into develop Nov 1, 2024
6 checks passed
@MarcoRocchietti MarcoRocchietti deleted the tickets/DM-46983 branch November 1, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants