Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-46477: Improve error reporting in ATCalsys.prepare_for_flat #167

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

cvillalon
Copy link
Contributor

No description provided.

@cvillalon
Copy link
Contributor Author

cvillalon commented Sep 25, 2024

@tribeiro I couldn't come up with a way to test this so I'm open to any suggestions. I'm leaving this PR as Draft until we figure this out.

@cvillalon cvillalon requested a review from tribeiro September 25, 2024 17:03
@cvillalon cvillalon marked this pull request as draft September 25, 2024 17:03
@cvillalon
Copy link
Contributor Author

@tribeiro I've added a test case for this improvement so I'm leaving the PR open and ready for review.

@cvillalon cvillalon marked this pull request as ready for review September 27, 2024 16:03
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cvillalon cvillalon merged commit 2f8ace0 into develop Sep 30, 2024
5 checks passed
@cvillalon cvillalon deleted the tickets/DM-46477 branch September 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants