DM-46276: modified wavelength change and setup laser

[parfa30]

Changing the laser wavelength and setup laser functions in mtcalsys so are more usable in a variety of sal scripts.

[edennihy]

Hi Parker, I added a handful of recommended changes and suggestions to start here. @tribeiro actually looked at most of them together to make sure we were in agreement, so we should be pretty close to finished once these changes are in.

One other missing piece is the unit tests for these methods. The nice part about that though is since they are being unit tested here, you will not need to test them again in the scripts when they are used.

[edennihy]

I think you can remove this comment

[edennihy]

Thanks for the changes, please see my final comments to help improve the docnotes. Otherwise, you can feel free to squash the commits and prepare to merge.

The last thing we need are a few unit tests for these methods. You could follow the examples here for how to setup a set of basic tests for these methods:

Example method ->

ts_observatory_control/python/lsst/ts/observatory/control/maintel/mtcs.py

Line 199 in 30f7d56

async def disable_ccw_following(self) -> None:

Example Unit Test ->

ts_observatory_control/tests/maintel/test_mtcs.py

Line 544 in 30f7d56

async def test_disable_ccw_following(self) -> None:

[edennihy]

Typo here, should be self.rem.tunablelaser.evt_

[edennihy]

This comment still needs to be resolved.

[edennihy]

and here, should be self.rem.tunablelaser.evt_

[edennihy]

Still needs to be resolved.

[edennihy]

The features index from zero, so this file should actually be named feature.1.rst

[edennihy]

Could you be a bit more specific in a few bullet points about the changes here? We could for example list the new methods and a quick description of they did. Here is an example of how to format this in the rst file https://github.com/lsst-ts/ts_observatory_control/blob/develop/doc/news/DM-46458.feature.rst

Add feature to allow ``ATCalSys`` to skip monochromator configuration.

- In ``atcalsys_schema.yaml``, add default values for wavelength, entrace_slit and exit_slit.
Add option to set monochromator_grating to None to skip monchromator configuration and set None as default value.
- In ``atcalsys.py``, add feature to skip configuring monochromator if monchromator_grating is None.
- In ``atcalsys.yaml``, update monochromator configuration values for ptc curves to skip monchromator configuration.

Which then displays like this:
Add feature to allow ATCalSys to skip monochromator configuration.

• In atcalsys_schema.yaml, add default values for wavelength, entrace_slit and exit_slit.
  Add option to set monochromator_grating to None to skip monchromator configuration and set None as default value.
• In atcalsys.py, add feature to skip configuring monochromator if monchromator_grating is None.
• In atcalsys.yaml, update monochromator configuration values for ptc curves to skip monchromator configuration.

[edennihy]

Looks good, thanks for all the changes!