Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 1794 #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Tickets/sitcom 1794 #2

wants to merge 4 commits into from

Conversation

edennihy
Copy link

No description provided.

Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small rewording suggestion but looks good.


.. abstract::

This document explains the procedure of what to do when a new filter is added (or going to be added) to the system. Several steps are required in order to ensure ingestion by the Butler such that the data can be served.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remember to use semantic line breaking, e.g.; split the 2 phrases in 2 separate lines.

Also, this abstract reads a bit funny. I suggest you rephrase it to something like this:

This document explains the required procedures when replacing or adding a new, previously uninstalled, filter or grating to LATISS.
These steps are required before any data is taken, in order to guarantee the data is correctly handled by the acquisition and ingestion system.




Introduction
============

Adding a filter or disperser to LATISS is a multi-step procedure that spans the DM and T&S subsystems.
Changing a filter or disperser in LATISS requires a few steps to make sure the instrument is properly configured and check data ingestion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rephrase:

Replacing a filter or disperser in LATISS requires a few steps to ensure that the instrument is properly configured and that data ingestion is working correctly.




Introduction
============

Adding a filter or disperser to LATISS is a multi-step procedure that spans the DM and T&S subsystems.
Changing a filter or disperser in LATISS requires a few steps to make sure the instrument is properly configured and check data ingestion.
Adding new, previously uninstalled a filter or disperser to LATISS is a multi-step procedure that spans the DM and T&S subsystems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rephrase:

When adding new, previously uninstalled filter or disperser requires additional steps that spans both DM and T&S subsystems.
Some of these steps may take some time to be ready to be rolled out to the summit and should be done well in advance to prevent delaying operations.

This technote is a list of things to do in order to have the data be taken with the correct metadata, as well as what it takes to get the files ingested on the summit.

.. important::

The most time critical step is updating filters.py (see below) and having it be built in a regular weekly that is accessible from the summit environment.
When adding a new, previously uninstalled filter, The most time critical step is updating the `filters definition file <https://github.com/lsst/obs_lsst/blob/main/python/lsst/obs/lsst/filters.py>`_ (see below) and having it be built in a regular weekly that is accessible from the summit environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove capitalization in "The" -> "the"

When adding a new, previously uninstalled filter, the most time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants