Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruby2_keywords for ruby 3 compatibility (#109) #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drstrangelooker
Copy link
Contributor

@drstrangelooker drstrangelooker commented Jan 11, 2025

To deal with keyword argument incompatibilities between Ruby 3 and earlier versions (see https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/), we can use the ruby2_keywords gem to decorate some of the functions that currently use the def method(*args) pattern that breaks in 3.0

@drstrangelooker drstrangelooker requested a review from a team as a code owner January 11, 2025 03:20
Copy link

Ruby-CI Tests

   24 files     24 suites   3m 36s ⏱️
   73 tests    73 ✅ 0 💤 0 ❌
1 644 runs  1 644 ✅ 0 💤 0 ❌

Results for commit 898940e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants