Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): remove fields marked as hidden from measures and dimensions #49

Merged

Conversation

pjabl
Copy link
Contributor

@pjabl pjabl commented Jun 14, 2024

Updating extension useLookerFields hook functionality to exclude hidden fields.
The changes ensure that fields marked as hidden in LookML are not available for LLM context generation.

Fixes #47

@pjabl pjabl requested a review from a team as a code owner June 14, 2024 05:36
Copy link

google-cla bot commented Jun 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pjabl pjabl force-pushed the fix-47-exclude-hidden-fields branch from 24773f9 to 90221dd Compare June 14, 2024 07:29
Copy link
Collaborator

@LukaFontanilla LukaFontanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjabl, thank you for the PR! This is a great addition to maintain parity with what we'd expect in the Looker UI.

@LukaFontanilla LukaFontanilla merged commit 4947875 into looker-open-source:main Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden LookML fields are included in Gemini-Pro Context
2 participants