Undo changes from 4.3.2

looker-open-source · Jan 3, 2025 · 4d850cd · 4d850cd
1 parent a38cd59
commit 4d850cd
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 16 deletions.
diff --git a/...my-projects/33-w1-tests/01-good.view.lkml → ...y-projects/.33-w1-tests/01-good.view.lkml b/...my-projects/33-w1-tests/01-good.view.lkml → ...y-projects/.33-w1-tests/01-good.view.lkml
diff --git a/...mmy-projects/33-w1-tests/02-bad.view.lkml → ...my-projects/.33-w1-tests/02-bad.view.lkml b/...mmy-projects/33-w1-tests/02-bad.view.lkml → ...my-projects/.33-w1-tests/02-bad.view.lkml
diff --git a/...ests/03-old-cc-indented-nospace.view.lkml → ...ests/03-old-cc-indented-nospace.view.lkml b/...ests/03-old-cc-indented-nospace.view.lkml → ...ests/03-old-cc-indented-nospace.view.lkml
diff --git a/...-tests/04-new-cc-indented-space.view.lkml → ...-tests/04-new-cc-indented-space.view.lkml b/...-tests/04-new-cc-indented-space.view.lkml → ...-tests/04-new-cc-indented-space.view.lkml
diff --git a/.../dummy-projects/33-w1-tests/index.test.js → ...y-projects/.33-w1-tests/index.test.js.txt b/.../dummy-projects/33-w1-tests/index.test.js → ...y-projects/.33-w1-tests/index.test.js.txt
diff --git a/.../dummy-projects/33-w1-tests/manifest.lkml → ...dummy-projects/.33-w1-tests/manifest.lkml b/.../dummy-projects/33-w1-tests/manifest.lkml → ...dummy-projects/.33-w1-tests/manifest.lkml
diff --git a/...-projects/33-w1-tests/my_model.model.lkml → ...projects/.33-w1-tests/my_model.model.lkml b/...-projects/33-w1-tests/my_model.model.lkml → ...projects/.33-w1-tests/my_model.model.lkml
diff --git a/docs/release-notes/v3.md b/docs/release-notes/v3.md
@@ -100,4 +100,5 @@ LookML Dashboards are now supported. This functionality is disabled by default.
 Patches:
 
 - v3.4.1 - Dependency updates in LAMS for jsonpath-plus. Dependency updates in Rule Sandbox for webpack and sub-dependencies.
-- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. 
+- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. 
+- v3.4.3 - Reverts v3.4.2, leaving whitespace handling as-is. New whitespace handling will be introduced as a breaking change in v4.
diff --git a/npm-shrinkwrap.dev.json b/npm-shrinkwrap.dev.json
@@ -13,7 +13,7 @@
         "fromentries": "^1.3.2",
         "jsonpath-plus": "^10.2.0",
         "liyad": "^0.2.4",
-        "lookml-parser": "^6.11.0",
+        "lookml-parser": "^6.10.0",
         "minimist": "^1.2.6",
         "require-from-string": "^2.0.2"
       },
@@ -3862,9 +3862,9 @@
       "dev": true
     },
     "node_modules/lookml-parser": {
-      "version": "6.11.0",
-      "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz",
-      "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==",
+      "version": "6.10.0",
+      "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz",
+      "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==",
       "dependencies": {
         "bluebird": "^3.5.1",
         "glob": "^7.1.2",
@@ -8052,9 +8052,9 @@
       "dev": true
     },
     "lookml-parser": {
-      "version": "6.11.0",
-      "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz",
-      "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==",
+      "version": "6.10.0",
+      "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz",
+      "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==",
       "requires": {
         "bluebird": "^3.5.1",
         "glob": "^7.1.2",

diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "fromentries": "^1.3.2",
     "jsonpath-plus": "^10.2.0",
     "liyad": "^0.2.4",
-    "lookml-parser": "^6.11.0",
+    "lookml-parser": "^6.10.0",
     "minimist": "^1.2.6",
     "require-from-string": "^2.0.2"
   },