Build more projects with llvm-x86_64-debian-dylib #37
Conversation
We want to expand the dylib testing to include libclang-cpp.so and also to build projects like lld, lldb, and clang-tools-extra that consume the dylibs.
|
@gkistanova Is there some way to test this change out in staging before it is pushed to the production server? |
| @@ -2324,8 +2324,8 @@ | |||
| 'builddir': 'llvm-x86_64-debian-dylib', | |||
There was a problem hiding this comment.
Shall the builder be renamed to reflect its new scope?
There was a problem hiding this comment.
I thought about that, but wasn't sure exactly what to call it? llvm-project-x86_64-dylib?
|
@tstellar You can either commit, wait for a couple of hours, and connect the worker to staging. This way you will be able to see how it works before the changes will go to the production. Or if anything in particular worries you, talk to me and I'll stage the patch for you without committing. usually committed changes go to production on Fridays or over a weekend. The patch itself looks good. But you need to decide between #37 and #39. If I get it right, these 2 patches are mutually exclusive? |
I don't think they are necessarily mutually exclusive. @serge-sans-paille is saying we should use both configs. |
We want to expand the dylib testing to include libclang-cpp.so and also to build projects like lld, lldb, and clang-tools-extra that consume the dylibs.