Skip to content

Commit

Permalink
[sanitize] Don't build older then 1h requests
Browse files Browse the repository at this point in the history
Temp workaround for #250.
  • Loading branch information
vitalybuka committed Aug 23, 2024
1 parent 73d07e0 commit c6560e5
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion zorg/buildbot/builders/sanitizers/buildbot_functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ function buildbot_update {
git checkout -f "${BUILDBOT_REVISION}"
git status
git rev-list --pretty --max-count=1 HEAD
# FIXME: Workaround for https://github.com/llvm/llvm-zorg/issues/250
[[ "${SKIP_OLD:-1}" == "0" ]] || (git log -1 --after='3 hours ago' | grep .) || {
echo Revision is not recent enough
exit 1
}
) || { build_exception ; exit 1 ; }
LLVM=$ROOT/llvm-project/llvm
fi
Expand Down Expand Up @@ -204,7 +209,7 @@ function build_clang_at_release_tag {
then
echo "@@@BUILD_STEP using pre-built stage1 clang at r${host_clang_revision}@@@"
else
BUILDBOT_MONO_REPO_PATH= BUILDBOT_REVISION="${host_clang_revision}" buildbot_update
SKIP_OLD=0 BUILDBOT_MONO_REPO_PATH= BUILDBOT_REVISION="${host_clang_revision}" buildbot_update

rm -rf ${STAGE1_DIR}
echo @@@BUILD_STEP build stage1 clang at $host_clang_revision@@@
Expand Down

3 comments on commit c6560e5

@nikic
Copy link

@nikic nikic commented on c6560e5 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side effect of this change is that it's no longer possible to bisect old revisions.

@vitalybuka
Copy link
Contributor Author

@vitalybuka vitalybuka commented on c6560e5 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side effect of this change is that it's no longer possible to bisect old revisions.

Unfortunately yes. But still better than having bot lagging by 2-3 days.

@vitalybuka
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side effect of this change is that it's no longer possible to bisect old revisions.

This should help #264

Please sign in to comment.