Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][xegpu] DCE decl in TD #121249

Merged
merged 1 commit into from
Dec 30, 2024
Merged

[mlir][xegpu] DCE decl in TD #121249

merged 1 commit into from
Dec 30, 2024

Conversation

makslevental
Copy link
Contributor

This builder isn't implemented and so the decl causes linker errors in certain build configurations.

This builder isn't implemented and so the decl causes linker errors in certain build configurations.
@llvmbot
Copy link
Member

llvmbot commented Dec 28, 2024

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-gpu

Author: Maksim Levental (makslevental)

Changes

This builder isn't implemented and so the decl causes linker errors in certain build configurations.


Full diff: https://github.com/llvm/llvm-project/pull/121249.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td (+2-4)
diff --git a/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td b/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
index 2aaa7fd4221ab1..4841f94de75f4a 100644
--- a/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
+++ b/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
@@ -164,11 +164,9 @@ def XeGPU_SGMapAttr : XeGPUAttr<"SGMap", "sg_map"> {
   }];
   let parameters = (ins
     ArrayRefParameter<"uint32_t">:$wi_layout,
-    ArrayRefParameter<"uint32_t">:$wi_data);
+    ArrayRefParameter<"uint32_t">:$wi_data
+  );
 
-  let builders = [
-    AttrBuilder<(ins)>
-  ];
 
   let hasCustomAssemblyFormat = 1;
   let genVerifyDecl = 1;

@makslevental makslevental merged commit 60d2060 into main Dec 30, 2024
11 checks passed
@makslevental makslevental deleted the users/makslevental/fix-xegpu branch December 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants