Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin at the bottom of "Main article:" boxes #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

i-ky
Copy link
Contributor

@i-ky i-ky commented Oct 4, 2022

This fixes the issue when the bottom "Main article:" box may be displayed partially outside of the parent <main> element. The issue can be observed on Design of clangd page.

Before After
image image

Note that spacing between the rest of "Main article:" boxes and subsequent headings increases as well, slightly bloating the page vertically. I hope it is acceptable.

Before After
image image

This fixes the issue when the bottom "Main article:" box may be
displayed partially outside of the parent <main> element.
@i-ky
Copy link
Contributor Author

i-ky commented Jan 20, 2023

@sam-mccall, @hokein, @njames93, could you please have a look? You have previously committed to the file I am changing.

@i-ky
Copy link
Contributor Author

i-ky commented Nov 10, 2023

@sam-mccall, @hokein, @njames93, could you please give me some feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant