Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term::has_free_variables: check if an expression has free variables #54

Merged
merged 3 commits into from
May 30, 2024

Conversation

AgentElement
Copy link
Contributor

What it says on the tin: this function returns true if a Term describes an expression that has at least one free variable. The undefined variable (Var(0)) is always considered free.

@AgentElement AgentElement changed the title Term::has_free_variables Term::has_free_variables: check if an expression has free variables May 30, 2024
src/term.rs Outdated Show resolved Hide resolved
src/term.rs Show resolved Hide resolved
Copy link
Owner

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again; left a few comments.

Copy link
Owner

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ljedrz ljedrz merged commit 971f18f into ljedrz:master May 30, 2024
4 checks passed
@ljedrz
Copy link
Owner

ljedrz commented May 30, 2024

BTW @AgentElement do you plan on any more contributions in the near future? I'm wondering when I should cut a release with your fix and new features.

@AgentElement
Copy link
Contributor Author

I only planned these three PRs, so I think it's safe to cut a new release now. I'm working on replicating a paper, so I do plan on more contributions in the future, but they may not be for a short while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants